-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move amplify config into common module #763
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
import { Amplify } from '../../src/Common'; | ||
|
||
describe('Amplify config test', () => { | ||
test('happy case', () => { | ||
const mockComp = { | ||
configure: jest.fn() | ||
} | ||
|
||
Amplify.register(mockComp); | ||
const res = Amplify.configure({ | ||
attr: 'attr' | ||
}); | ||
|
||
expect(mockComp.configure).toBeCalled(); | ||
expect(res).toEqual({ attr: 'attr' }); | ||
}); | ||
|
||
test('empty config', () => { | ||
const mockComp = { | ||
configure: jest.fn() | ||
} | ||
|
||
Amplify.register(mockComp); | ||
const res = Amplify.configure(null); | ||
|
||
expect(mockComp.configure).not.toBeCalled(); | ||
}); | ||
}); | ||
|
||
describe('addPluggable test', () => { | ||
test('happy case', () => { | ||
const pluggable = { | ||
getCategory: jest.fn() | ||
} | ||
|
||
const mockComp = { | ||
addPluggable: jest.fn() | ||
} | ||
|
||
Amplify.register(mockComp); | ||
Amplify.addPluggable(pluggable); | ||
|
||
expect(mockComp.addPluggable).toBeCalled(); | ||
}); | ||
|
||
test('no pluggable', () => { | ||
const pluggable = { | ||
getCategory: jest.fn() | ||
} | ||
|
||
const mockComp = { | ||
addPluggable: jest.fn() | ||
} | ||
|
||
Amplify.addPluggable({}); | ||
|
||
expect(mockComp.addPluggable).not.toBeCalled(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
import { ConsoleLogger as Logger } from './Logger'; | ||
|
||
const logger = new Logger('Amplify'); | ||
|
||
export default class Amplify { | ||
private static _components = []; | ||
private static _config = {}; | ||
|
||
// for backward compatibility to avoid breaking change | ||
// if someone is using like Amplify.Auth | ||
static Auth = null; | ||
static Analytics = null; | ||
static API = null; | ||
static Storage = null; | ||
static I18n = null; | ||
static Cache = null; | ||
static PubSub = null; | ||
|
||
static Logger = null; | ||
|
||
static register(comp) { | ||
logger.debug('component registed in amplify', comp); | ||
this._components.push(comp); | ||
} | ||
|
||
static configure(config) { | ||
if (!config) return this._config; | ||
|
||
this._config = Object.assign(this._config, config); | ||
logger.debug('amplify config', this._config); | ||
this._components.map(comp => { | ||
comp.configure(this._config); | ||
}); | ||
|
||
return this._config; | ||
} | ||
|
||
static addPluggable(pluggable) { | ||
if (pluggable && pluggable['getCategory'] && typeof pluggable['getCategory'] === 'function') { | ||
this._components.map(comp => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where is checking the category for the component to be the same for the plugin? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It will be checked in each category's |
||
if (comp['addPluggable'] && typeof comp['addPluggable'] === 'function') { | ||
comp.addPluggable(pluggable); | ||
} | ||
}); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are any of this being used? I think component should have a category so it can be attached.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are just for backward compatibility since they will be assigned in
aws-amplify/index.ts
and developers may callinstead of
Will add some comments on that.