Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(@aws-amplify/datastore): add tests for issue 7888 #7936

Conversation

iartemiev
Copy link
Member

@iartemiev iartemiev commented Mar 14, 2021

Draft until #7935 and #7354 are merged.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #7936 (e59ab19) into main (efd2e41) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7936      +/-   ##
==========================================
+ Coverage   74.80%   74.82%   +0.02%     
==========================================
  Files         215      215              
  Lines       13522    13522              
  Branches     2661     2661              
==========================================
+ Hits        10115    10118       +3     
+ Misses       3208     3205       -3     
  Partials      199      199              
Impacted Files Coverage Δ
packages/datastore/src/sync/outbox.ts 93.15% <0.00%> (+4.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd2e41...e59ab19. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Mar 14, 2021

This pull request introduces 1 alert when merging c201772 into 0218cf5 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@iartemiev iartemiev force-pushed the ds-update-mutation-consecutive-writes branch from c201772 to 8516f75 Compare March 14, 2021 18:29
@iartemiev iartemiev force-pushed the ds-update-mutation-consecutive-writes branch from 8516f75 to e59ab19 Compare March 25, 2021 16:57
@iartemiev iartemiev marked this pull request as ready for review March 25, 2021 17:01
@iartemiev
Copy link
Member Author

This is included in #8000. Closing

@iartemiev iartemiev closed this Mar 29, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant