Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update examples and solutions for graphql broken link #6477

Closed
wants to merge 1 commit into from

Conversation

elorzafe
Copy link
Contributor

Description of changes:

update examples and solutions for graphql broken link

Related GitHub issue #, if available:

Broken link for Examples and solutions

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • iOS
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://link.com)
    HTML: <a href="https://link.com">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@elorzafe elorzafe requested review from renebrandel and a team as code owners November 17, 2023 18:01
@@ -465,6 +465,6 @@ There's so much more to discover with Amplify's GraphQL API capabilities. Learn
- [Add custom business logic to the GraphQL API](/[platform]/build-a-backend/graphqlapi/custom-business-logic/)
- [Run search and result aggregation queries](/[platform]/build-a-backend/graphqlapi/search-and-result-aggregations/)
- [Connect to machine learning services](/[platform]/build-a-backend/graphqlapi/connect-machine-learning-services/)
- [Examples and solutions](/[platform]/build-a-backend/graphqlapi/best-practice/)
- [Examples and solutions](/javascript/build-a-backend/graphqlapi/best-practice/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this page available on other platforms?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes all JS family pages can use this page and swift - I would suggest we either take it out from this page entirely or use the inline filter vs make a direct link. @renebrandel could we remove this link from the Set up page? If anything I think we would want to check the links on reading data and make sure this has a link from there right or set up with a filter

@reesscot
Copy link
Member

Realizing the issue is that react-native and flutter aren't listed here:
https://github.com/aws-amplify/docs/blob/main/src/pages/%5Bplatform%5D/build-a-backend/graphqlapi/best-practice/index.mdx#L8

@heatheramz
Copy link
Contributor

@elorzafe Just a follow up that this PR can be closed - the related filters and docs were updated in this PR #6530

@heatheramz heatheramz closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants