Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look at top level function in a condition #1235

Merged
merged 2 commits into from
Dec 2, 2019

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Dec 2, 2019

Issue #, if available:
#1221
Description of changes:

  • Validate the top level function when defining a condition

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #1235 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1235      +/-   ##
==========================================
+ Coverage   87.32%   87.33%   +<.01%     
==========================================
  Files         136      136              
  Lines        8058     8062       +4     
  Branches     1982     1984       +2     
==========================================
+ Hits         7037     7041       +4     
  Misses        598      598              
  Partials      423      423
Impacted Files Coverage Δ
src/cfnlint/rules/conditions/Configuration.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aeaaac...14a6ae1. Read the comment docs.

@kddejong kddejong merged commit 635b962 into aws-cloudformation:master Dec 2, 2019
@kddejong kddejong deleted the Fix/1221 branch December 2, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant