Fix issues with spec in wafv2 RegularExpressionList #1300
Conversation
|
Confirmed that the spec is wrong and that the new changes will both pass cfn-lint and result in a successful deployment. |
Codecov Report
@@ Coverage Diff @@
## master #1300 +/- ##
=======================================
Coverage 87.62% 87.62%
=======================================
Files 137 137
Lines 8123 8123
Branches 1995 1995
=======================================
Hits 7118 7118
Misses 597 597
Partials 408 408Continue to review full report at Codecov.
|
| "path": "/ResourceTypes/AWS::WAFv2::RegexPatternSet/Properties/RegularExpressionList", | ||
| "value": { | ||
| "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-regexpatternset-regularexpressionlist.html#cfn-wafv2-regexpatternset-regularexpressionlist-regularexpressionlist", | ||
| "ItemType": "Regex", |
There was a problem hiding this comment.
| "ItemType": "Regex", | |
| "PrimitiveItemType": "String", |
still getting: E3002: Expecting an object at Resources/RegexPatternSet/Properties/RegularExpressionList/0
with this deployable template:
Resources:
RegexPatternSet:
Type: AWS::WAFv2::RegexPatternSet
Properties:
Name: Name
Scope: REGIONAL
RegularExpressionList:
- RegularExpressionWill check if the RegexString property is also valid
|
@PatMyron are you saying this is wrong too? https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-regexpatternset-regex.html |
Resources:
RegexPatternSet:
Type: AWS::WAFv2::RegexPatternSet
Properties:
Name: Name
Scope: REGIONAL
RegularExpressionList:
- RegexString: RegularExpressionalso successfully deploys and now successfully lints, so this is probably fine |
Issue #, if available:
Fix #1286
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.