Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more patching for wafv2 resources #1313

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Jan 14, 2020

Issue #, if available:
Fix #1312
Description of changes:

  • Patch more of the wafv2 specs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #1313 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1313   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files         137      137           
  Lines        8125     8125           
  Branches     1996     1996           
=======================================
  Hits         7119     7119           
  Misses        597      597           
  Partials      409      409

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4618df2...ecbd3b5. Read the comment docs.

@kddejong kddejong merged commit 89b165f into aws-cloudformation:master Jan 15, 2020
@kddejong kddejong deleted the Fix/1312 branch January 15, 2020 03:37
@PatMyron PatMyron added the spec CloudFormation Specification Bug label Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec CloudFormation Specification Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E3002 error on valid AWS::WAFv2::WebACL resource
2 participants