Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tagging examples #3448

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

michael-k
Copy link
Contributor

Issue #, if available: n/a

Description of changes: The examples no longer worked with cfn-lint v1. The PropertiesTagsRequired probably didn't work with v0 either, because it didn't account for resources that use objects as tags, eg. AWS::SSM::Parameter.

Instead of "Tags" in schema.schema["properties"] I wanted to use (schema.schema.get("tagging") or {}).get("taggable"), but that doesn't work with AWS::ApiGatewayV2::Stage ("tagging" not in schema.schema, but the resource supports tags). Happend to have that resource in our test suite, there might be more where this doesn't work. (See also this message at discord.)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (3724d31) to head (8106318).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3448      +/-   ##
==========================================
- Coverage   93.30%   93.29%   -0.01%     
==========================================
  Files         324      324              
  Lines       11055    11055              
  Branches     2316     2316              
==========================================
- Hits        10315    10314       -1     
  Misses        415      415              
- Partials      325      326       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit abe3691 into aws-cloudformation:main Jun 28, 2024
22 checks passed
@michael-k michael-k deleted the tagging-examples branch June 28, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants