Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create relationship rule and validate ImageId on Instance #3513

Merged

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Jul 17, 2024

Issue #, if available:
fix #3473
fix #817
Description of changes:

  • Create relationship rule and validate ImageId on Instance
  • Create rule E3673 to validate ImageId being required on an instance
  • Create rule E3049 to validate ECS Task/Service and LB target configuration with dynamic host ports

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 97.76786% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.61%. Comparing base (fbdd7fa) to head (08420ca).

Files Patch % Lines
src/cfnlint/context/context.py 60.00% 1 Missing and 1 partial ⚠️
src/cfnlint/rules/helpers/get_value_from_path.py 95.45% 1 Missing and 1 partial ⚠️
...cfnlint/rules/resources/ecs/ServiceDynamicPorts.py 98.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3513      +/-   ##
==========================================
+ Coverage   93.54%   93.61%   +0.06%     
==========================================
  Files         343      348       +5     
  Lines       11472    11682     +210     
  Branches     2404     2471      +67     
==========================================
+ Hits        10732    10936     +204     
- Misses        413      415       +2     
- Partials      327      331       +4     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the feature/rules/relationships branch 4 times, most recently from b0d3a24 to 1c2e463 Compare July 18, 2024 21:29
@kddejong kddejong force-pushed the feature/rules/relationships branch from 1c2e463 to 2d31429 Compare July 25, 2024 17:54
@kddejong kddejong force-pushed the feature/rules/relationships branch 2 times, most recently from 169409a to 14373b1 Compare July 26, 2024 00:04
@kddejong kddejong force-pushed the feature/rules/relationships branch from 14373b1 to 08420ca Compare July 26, 2024 18:41
@kddejong kddejong merged commit e46a0d2 into aws-cloudformation:main Jul 26, 2024
22 checks passed
@kddejong kddejong deleted the feature/rules/relationships branch July 26, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant