Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for rule Equals when static #3659

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Sep 4, 2024

Issue #, if available:
fix #3658

Description of changes:

  • Better support for rule Equals when static
  • Catch rule building exceptions and return True

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 70.27027% with 11 lines in your changes missing coverage. Please review.

Project coverage is 93.66%. Comparing base (31d4036) to head (4d35f22).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/cfnlint/conditions/_rule.py 58.33% 5 Missing ⚠️
src/cfnlint/conditions/conditions.py 64.28% 4 Missing and 1 partial ⚠️
src/cfnlint/conditions/_condition.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3659      +/-   ##
==========================================
- Coverage   93.73%   93.66%   -0.07%     
==========================================
  Files         356      356              
  Lines       12143    12169      +26     
  Branches     2607     2613       +6     
==========================================
+ Hits        11382    11398      +16     
- Misses        418      426       +8     
- Partials      343      345       +2     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit b89eb11 into aws-cloudformation:main Sep 4, 2024
20 of 22 checks passed
@kddejong kddejong deleted the fix/issue/3658 branch September 4, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cfn-lint is failing when trying to lint templates in subdirectories
1 participant