Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically determine Account ID during transform #3749

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

kddejong
Copy link
Contributor

Issue #, if available:
fix #3747
Description of changes:

  • Dynamically determine Account ID during transform

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.74%. Comparing base (07652d4) to head (9c0de35).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...fnlint/template/transforms/_language_extensions.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3749      +/-   ##
==========================================
- Coverage   93.76%   93.74%   -0.02%     
==========================================
  Files         362      362              
  Lines       12341    12348       +7     
  Branches     2517     2520       +3     
==========================================
+ Hits        11571    11576       +5     
  Misses        430      430              
- Partials      340      342       +2     
Flag Coverage Δ
unittests 93.70% <87.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit dfb4390 into aws-cloudformation:main Oct 16, 2024
19 of 21 checks passed
@kddejong kddejong deleted the fix/issue/3747 branch October 16, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fn::ForEach could not be resolved when values array references Map using AccountId key
1 participant