Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logic to handle substitutions #3768

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Oct 18, 2024

Issue #, if available:
fix #3724
Description of changes:

  • add logic to handle substitutions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.76%. Comparing base (8e463fb) to head (b786784).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../resources/stepfunctions/StateMachineDefinition.py 93.10% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3768      +/-   ##
==========================================
- Coverage   93.77%   93.76%   -0.01%     
==========================================
  Files         362      362              
  Lines       12356    12371      +15     
  Branches     2521     2527       +6     
==========================================
+ Hits        11587    11600      +13     
  Misses        429      429              
- Partials      340      342       +2     
Flag Coverage Δ
unittests 93.72% <93.10%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the fix/issue/3724 branch 3 times, most recently from 8647690 to fae3164 Compare October 18, 2024 18:15
@kddejong kddejong merged commit a5672f0 into aws-cloudformation:main Oct 18, 2024
22 of 24 checks passed
@kddejong kddejong deleted the fix/issue/3724 branch October 18, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State machine definition is rejected
1 participant