Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip state machine validation when using a function #3770

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Oct 18, 2024

Issue #, if available:
fix #3769
Description of changes:

  • skip validation of E3601 when using a function for the definition

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.76%. Comparing base (a5672f0) to head (28305d3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3770      +/-   ##
==========================================
- Coverage   93.77%   93.76%   -0.01%     
==========================================
  Files         362      362              
  Lines       12371    12375       +4     
  Branches     2527     2528       +1     
==========================================
+ Hits        11601    11604       +3     
  Misses        429      429              
- Partials      341      342       +1     
Flag Coverage Δ
unittests 93.72% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 0a31357 into aws-cloudformation:main Oct 18, 2024
23 of 24 checks passed
@kddejong kddejong deleted the fix/issue/3769 branch October 18, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS::StepFunctions::StateMachine failure with Fn::Join etc.
1 participant