prepend the replacePkgAlias in model.ReplacePkgName only when it'…

…s not empty
aws-controllers-k8s · Jul 22, 2021 · 3a3f2f0 · 3a3f2f0
1 parent c1145b4
commit 3a3f2f0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/pkg/model/types.go b/pkg/model/types.go
@@ -139,11 +139,15 @@ func ReplacePkgName(
 	// alias the Kubernetes API types for the service API with that
 	if strings.Contains(memberType, ".") {
 		pkgName := strings.Split(memberType, ".")[0]
-		typeName := strings.Split(memberType, ".")[1]
+		memberType = strings.Split(memberType, ".")[1]
 		if pkgName == apiPkgName {
-			memberType = replacePkgAlias + "." + typeName
+			if replacePkgAlias != "" {
+				memberType = replacePkgAlias + "." + memberType
+			}
 		} else {
-			memberType = pkgName + "." + typeName
+			if replacePkgAlias != "" {
+				memberType = pkgName + "." + memberType
+			}
 		}
 	}
 	if isPointerType && keepPointer {

diff --git a/pkg/model/types_test.go b/pkg/model/types_test.go
@@ -66,6 +66,13 @@ func TestReplacePkgName(t *testing.T) {
 			true,
 			"[][]*svcsdk.EC2TagFilter",
 		},
+		{ // empty replacePkgAlias
+			"*ecr.Repository",
+			"ecr",
+			"",
+			true,
+			"*Repository",
+		},
 	}
 
 	for _, tc := range testCases {