Skip to content

Commit

Permalink
fixing formatting in container image to be consistent with image (#206)
Browse files Browse the repository at this point in the history
Issue #, if available:
N/A

Description of changes:
This PR aims to keep how `containerImage` tag is generated/built consistent and insync with how `image` tag in the cluster service version is generated. This makes readability of both sections of code/templates/sh's/etc the same and easier in the future if a change in the formate is needed.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • Loading branch information
acornett21 authored Sep 23, 2021
1 parent c484422 commit e4d7c2a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/generate/olm/olm.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ func DefaultServiceConfig() ServiceConfig {
SuggestedNamespace: "ack-system",
ShortDescription: "This is the placeholder short description for the default configuration",
IsCertified: false,
ContainerImage: "public.ecr.aws/aws-controllers-k8s/",
ContainerImage: "public.ecr.aws/aws-controllers-k8s",
Support: "Community",
},
[]Sample{},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ metadata:
capabilities: {{.Annotations.CapabilityLevel}}
operatorframework.io/suggested-namespace: "ack-system"
repository: {{.Annotations.Repository}}
containerImage: {{.Annotations.ContainerImage}}{{.ServiceIDClean}}-controller:v{{.Version}}
containerImage: {{.Annotations.ContainerImage}}/{{.ServiceIDClean}}-controller:v{{.Version}}
description: {{.Annotations.ShortDescription}}
createdAt: {{.CreatedAt}}
support: {{.Annotations.Support}}
Expand Down

0 comments on commit e4d7c2a

Please sign in to comment.