Use go-git functionalities for common git operations
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs |
ack-bot
added
the
do-not-merge/hold
a-hilaly
force-pushed
the
go-git
branch
2 times, most recently
from
ecc9b22 to
6371c7b
Compare
| ) | ||
|
|
||
| // LoadRepository loads a repository from the local file system. | ||
| // TODO(a-hilaly): load repository into a memory filesystem (needs go1.16 |
There was a problem hiding this comment.
How large would this be in memory? I know the aws-sdk-go has a large commit history and many, many tags.
There was a problem hiding this comment.
du -sh ~/.cache/aws-controllers-k8s/src/aws-sdk-go
352M /Users/hilalymh/.cache/aws-controllers-k8s/src/aws-sdk-goI guess it's gonna be ~350M - I will do some profile on ack-generate binary before implementing it
There was a problem hiding this comment.
@RedbackThomson Is it a bad a idea to load such a big repository in memory?
13 tasks
command using `os/exec` This patch updates all the helper functions to use `go-git` library instead of having to call `os/exec.Command`/`os/exec.CombinedOutput` in order to clone repository, fetch tags... These changes brings more dependencies to our `go.mod` but in exchange it simplifies the way we interact with git repositories and improves errors handling and readability. Future changes will also benefit from this patch, especially conversation webhook generator that will need to checkout multiple version tags.
|
/unhold |
ack-bot
removed
the
do-not-merge/hold
|
/approve I am sure you tested this locally for some controller. Good to add the output in PR since there are no new unit tests. |
|
Adding unit tests |
ack-bot
added
the
do-not-merge/hold
|
Looks like it's very complex to unit test these util functions, and it's almost equivalent of testing the go-git library. @vijtrip2 and I agreed on leaving the PR as is and just run some local tests. On my local machine # First run (no local aws-sdk-go cache)
time ACK_GENERATE_CACHE_DIR=/tmp/gitest AWS_SDK_GO_VERSION=v1.38.60 make build-ack-generate build-controller SERVICE=ecr
building ack-generate ... ok.
Copying common custom resource definitions into ecr
Building Kubernetes API objects for ecr
Generating deepcopy code for ecr
Generating custom resource definitions for ecr
Building service controller for ecr
Generating RBAC manifests for ecr
Running gofmt against generated code for ecr
ACK_GENERATE_CACHE_DIR=/tmp/gitest AWS_SDK_GO_VERSION=v1.38.60 make 54,08s user 3,20s system 50% cpu 1:53,98 total
# Second run
time ACK_GENERATE_CACHE_DIR=/tmp/gitest AWS_SDK_GO_VERSION=v1.38.60 make build-ack-generate build-controller SERVICE=ecr
building ack-generate ... ok.
Copying common custom resource definitions into ecr
Building Kubernetes API objects for ecr
Generating deepcopy code for ecr
Generating custom resource definitions for ecr
Building service controller for ecr
Generating RBAC manifests for ecr
Running gofmt against generated code for ecr
ACK_GENERATE_CACHE_DIR=/tmp/gitest AWS_SDK_GO_VERSION=v1.38.60 make 8,04s user 1,27s system 176% cpu 5,264 total/unhold |
ack-bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ryansteakley
added a commit
to ryansteakley/code-generator
that referenced
this pull request
Jul 1, 2021
# This is the 1st commit message: add new field to pkg/generate/config.go so user can implement custom requiredFieldMissingFromReadOneInput # This is the commit message aws-controllers-k8s#2: Use `go-git` functionalities for common git operations (aws-controllers-k8s#108) Part of aws-controllers-k8s/community#835 This patch updates all the helper functions to use `go-git` library instead of having to call `os/exec.Command`/`os/exec.CombinedOutput` in order to clone repository, fetch tags... These changes brings more dependencies to our `go.mod` but in exchange it simplifies the way we interact with git repositories and improves errors handling and readability. Future changes will also benefit from this patch, especially conversation webhook generator that will need to checkout multiple version tags. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
RedbackThomson
pushed a commit
to RedbackThomson/ack-code-generator
that referenced
this pull request
Jul 8, 2021
…rs-k8s#108) Part of aws-controllers-k8s/community#835 This patch updates all the helper functions to use `go-git` library instead of having to call `os/exec.Command`/`os/exec.CombinedOutput` in order to clone repository, fetch tags... These changes brings more dependencies to our `go.mod` but in exchange it simplifies the way we interact with git repositories and improves errors handling and readability. Future changes will also benefit from this patch, especially conversation webhook generator that will need to checkout multiple version tags. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of aws-controllers-k8s/community#835
This patch updates all the helper functions to use
go-gitlibraryinstead of having to call
os/exec.Command/os/exec.CombinedOutputinorder to clone repository, fetch tags... These changes brings more
dependencies to our
go.modbut in exchange it simplifies the way weinteract with git repositories and improves errors handling and
readability.
Future changes will also benefit from this patch, especially
conversation webhook generator that will need to checkout multiple
version tags.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.