Copy generator.yaml to apis/version directory
#109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedbackThomson
suggested changes
Jun 25, 2021
cmd/ack-generate/command/apis.go
Outdated
| return fmt.Errorf("cannot copy generator configuration file: %v", err) | ||
| } | ||
|
|
||
| fmt.Println("copied to", copyDest) |
Adding some logic to create copies of the `generator.yaml` within the apis versions directories. These generator.yaml files we be reused by the conversion webhook generator to understand the difference between each two different API versions. This patch Also adds a new utility function to copy files from a source to a destination path.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of aws-controllers-k8s/community#835
Adding some logic to create copies of the
generator.yamlwithin theapis versions directories. These generator.yaml files we be reused by
the conversion webhook generator to understand the difference between
each two different API versions.
This patch Also adds a new utility function to copy files from a
source to a destination path.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.