Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default non-release version in build-controller-release.sh #162

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

vijtrip2
Copy link
Contributor

Description of changes:

  • With the latest addition of presubmit 'release-test' job, service teams are required to execute 'build-controller-release.sh ' script for a successful PR build. 'build-controller-release.sh' script takes VERSION as required parameter.
  • Sagemaker team provided the feedback on how they do not want to worry about controller versions until they are doing an actual release. which is fair.
  • So this code change, introduces a default version 'v0.0.0-non-release-version' which allows for successful release-test for service teams without worrying about what VERSION to use until actual release.
  • This code change also adds the validation for the VERSION parameter.

Why not use something like git describe --tags --always --dirty to generate version ?

  • The git command works in most cases if the repository already has a legit semver tag. If that is not the case then we need to add additional handling to create an actual semver tag.
  • Instead of dealing with all the edge cases with above command, having a static non-release version gets the job done. Because it is really just a placeholder value for the release-test execution.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks @vijtrip2!

@jaypipes
Copy link
Collaborator

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Aug 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypipes, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 5a886f9 into aws-controllers-k8s:main Aug 20, 2021
@vijtrip2 vijtrip2 deleted the default_version branch August 20, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants