Support ReadMany operations with slices in SetResourceIdentifiers
#170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
reviewed
Aug 26, 2021
Comment on lines
-3111
to
-3113
| f0, f0ok := identifier.AdditionalKeys["modelPackageName"] | ||
| if f0ok { | ||
| r.ko.Spec.ModelPackageName = &f0 |
There was a problem hiding this comment.
I figured that if you are querying by ARN, you will not need to define additional keys to filter down to a single element. ModelPackageName did not provide any value in this method, before. It was just being added because it was another field on the DescribeModelPackages API.
|
/test unit-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aws-controllers-k8s/community#874
Description of changes:
Automatically detects pluralised fields from the operation shape and sets the corresponding CR field. Refactor
SetResourceIdentifiersto re-use common logic fromCheckRequiredFieldsMissingFromShape. Now supportsprimary_identifier_field_namesthat reference[]stringtypes.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.