Add comparison support for blob type fields
#171
Conversation
There was a problem hiding this comment.
@a-hilaly want to add a unit test to https://github.com/aws-controllers-k8s/code-generator/blob/main/pkg/generate/code/compare_test.go for this new output?
Currently the code-generator panics whenever a CRD/type field is of type blob (array of bytes). This PR adds support for blob type comparison.
|
@jaypipes Added unit test for lambda functions |
| delta.Add("Spec.Code.S3ObjectVersion", a.ko.Spec.Code.S3ObjectVersion, b.ko.Spec.Code.S3ObjectVersion) | ||
| } | ||
| } | ||
| if !bytes.Equal(a.ko.Spec.Code.ZipFile, b.ko.Spec.Code.ZipFile) { |
There was a problem hiding this comment.
👍
(even though it's probably not a great idea for us to support ZipFile field the Function CRD, but that's a conversation for another day ;) )
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue N/A
Description of changes:
Currently the code-generator panics whenever a CRD/type field is of type blob (array of bytes). This PR adds support for blob type comparison.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.