visibility for AWS err code in addition to message #176
Conversation
surajkota
requested review from
jaypipes,
a-hilaly and
RedbackThomson
and removed request for
a-hilaly and
vijtrip2
super nit: |
yes, I am using same setup for testing |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brycahta, jaypipes, surajkota The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes: - bring in changes from aws-controllers-k8s/code-generator#175, aws-controllers-k8s/code-generator#176 - corresponding unit and integ test changes - fix some erroneous unit tests like model package group and endpoint config - fix invalid name in unit test - fix assertion in notebook instance test since PR build was failing and add it to missing canary cleanup Testing: unit test tested manually, rely on PR build, later we can add more unit tests for delete failed scenario By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description of changes:
Provide aws error code(e.g. Validation exception, InvalidParameterValue) in addition to message in the condition message
Testing:
Manually introduced an aws error from sdkDelete and verified it gets updated in conditions
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.