Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation of controller-gen in prowjobs #187

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

vijtrip2
Copy link
Contributor

@vijtrip2 vijtrip2 commented Sep 8, 2021

Issue #, if available:

Description of changes:

  • Fix installation of controller-gen in prowjobs
  • Installing controller-gen in prowjobs fail because $GOPATH/bin directory is not present.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RedbackThomson
Copy link
Contributor

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RedbackThomson, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RedbackThomson,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 394e829 into aws-controllers-k8s:main Sep 8, 2021
@vijtrip2 vijtrip2 deleted the install_path_fix branch September 8, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants