Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invocation of olm-create-bundle.sh to build-controller-release.sh #207

Merged

Conversation

trgeiger
Copy link
Contributor

@trgeiger trgeiger commented Sep 24, 2021

Issue #, if available: 972

Description of changes:
Adds olm-create-bundle.sh to the OLM conditional block of build-controller-release.sh. Also adds stripping the 'v' from $BUNDLE_RELEASE to prevent any breakage if the user has that variable including a 'v.'

fixes aws-controllers-k8s/community#972

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

build-controller-release.sh. Also handle the $RELEASE_VERSION variable
inside olm-create-bundle.sh to be compatible with the script.
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 24, 2021

Hi @trgeiger. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-bot ack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 24, 2021
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible, thanks @trgeiger :)

@jaypipes
Copy link
Collaborator

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypipes, trgeiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 2b0ac06 into aws-controllers-k8s:main Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build-controller-release.sh should also optionally create the OLM bundle on disk to be committed
3 participants