Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ServiceID reference to ServiceIDClean #214

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Rename ServiceID reference to ServiceIDClean #214

merged 1 commit into from
Oct 5, 2021

Conversation

trgeiger
Copy link
Contributor

@trgeiger trgeiger commented Oct 5, 2021

Issue #, if available:
aws-controllers-k8s/community#1009

Description of changes:
ServiceID was removed in a recent commit. One reference was left in clusterserviceversion.yaml.tpl. This PR simply renames that reference to ServiceIDClean to prevent breakage.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 5, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Oct 5, 2021

Hi @trgeiger. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vijtrip2
Copy link
Contributor

vijtrip2 commented Oct 5, 2021

/ok-to-test

@ack-bot ack-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 5, 2021
@RedbackThomson
Copy link
Contributor

Oops, sorry about that. Thanks

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Oct 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, RedbackThomson, trgeiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 5dabfd9 into aws-controllers-k8s:main Oct 5, 2021
RedbackThomson pushed a commit to RedbackThomson/ack-code-generator that referenced this pull request Oct 7, 2021
Revert "Rename ServiceID reference to ServiceIDClean (aws-controllers…
f722959 
…-k8s#214)"

This reverts commit 5dabfd9.
@RedbackThomson RedbackThomson mentioned this pull request Oct 7, 2021
Merged
ack-bot pushed a commit that referenced this pull request Oct 7, 2021
@RedbackThomson
Revert service model name argument (#215)
eaa7f22 
Description of changes:
Reverts #214 and #211 in favour of using the `generator.yaml` file to store the service model name

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
acornett21 pushed a commit to acornett21/ack-code-generator that referenced this pull request Oct 12, 2021
@trgeiger @acornett21
Rename ServiceID reference to ServiceIDClean (aws-controllers-k8s#214)
89459df 

Issue #, if available:
aws-controllers-k8s/community#1009

Description of changes:
ServiceID was removed in a recent commit. One reference was left in clusterserviceversion.yaml.tpl. This PR simply renames that reference to ServiceIDClean to prevent breakage.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
acornett21 pushed a commit to acornett21/ack-code-generator that referenced this pull request Oct 12, 2021
@RedbackThomson @acornett21
Revert service model name argument (aws-controllers-k8s#215)
edf97b3 
Description of changes:
Reverts aws-controllers-k8s#214 and aws-controllers-k8s#211 in favour of using the `generator.yaml` file to store the service model name

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acornett21 acornett21 acornett21 approved these changes

@jaypipes jaypipes Awaiting requested review from jaypipes

@RedbackThomson RedbackThomson Awaiting requested review from RedbackThomson

Assignees

@RedbackThomson RedbackThomson

Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trgeiger @ack-bot @vijtrip2 @RedbackThomson @acornett21