Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ENA to initialism list w/ preventions #227

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

bwagner5
Copy link
Member

Issue #, if available:
aws-controllers-k8s/ec2-controller#17

Description of changes:

  • Add ENA to initialism list and prevent "Enable" -> "ENAble" and "Enabling" -> "ENAbling"

Grep to find other Ena words in aws models:

$ grep -r 'Ena[a-zA-Z]*' -o .  | sort | uniq | grep -v "Enabl"
./ec2/2016-11-15/api-2.json:EnaSupport
./ec2/2016-11-15/docs-2.json:EnaSupport
./ec2/2016-11-15/examples-1.json:EnaSupport

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from a-hilaly and vijtrip2 October 19, 2021 22:48
@RedbackThomson
Copy link
Contributor

RedbackThomson commented Oct 19, 2021

Hopefully no-one is enamoured enough with this prefix to enact a new policy to enable it in any other models.

But don't quote me on that.

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Oct 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bwagner5, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit a328190 into aws-controllers-k8s:main Oct 19, 2021
@jaypipes
Copy link
Collaborator

Hopefully no-one is enamoured enough with this prefix to enact a new policy to enable it in any other models.

But don't quote me on that.

/lgtm

I see what you did there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants