Fix Spec field length #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
reviewed
Mar 22, 2022
| @@ -564,7 +564,8 @@ func CompareStruct( | |||
| var compareConfig *ackgenconfig.CompareFieldConfig | |||
| // memberFieldPath contains the field path along with the prefix cfg.PrefixConfig.SpecField + "." hence we | |||
| // would need to substring to exclude cfg.PrefixConfig.SpecField + "." to get correct field config. | |||
| fieldConfig := fieldConfigs[memberFieldPath[len(cfg.PrefixConfig.SpecField) + 1 :len(memberFieldPath)]] | |||
| specFieldLen := len(strings.TrimPrefix(cfg.PrefixConfig.SpecField, ".")) | |||
There was a problem hiding this comment.
This fix makes sense, i still wonder what part of elasticache/memorydb delta generated code was broken? can we add some unit tests? :)
|
Echoing @a-hilaly here - Please update the PR to include an issue describing the bug this is fixing, or describe the error directly in the PR body. I don't have any context for what this line of code is doing, or should be doing. |
Updated to trim the prefix "." to calculate the length.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nmvk, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to trim the prefix "." to calculate the length of the
Spec.cfg.PrefixConfig.SpecFieldvalue is.Specso old codelen(cfg.PrefixConfig.SpecField) + 1constructed incorrect field path and ignored the config set ingenerator.yamlAdded unit test to validate that below block is not generated.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.