Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Terminal Condition if ACK Terminal Error #318

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Set Terminal Condition if ACK Terminal Error #318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions templates/pkg/resource/sdk.go.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ package {{ .CRD.Names.Snake }}

import (
"context"
"errors"
"reflect"
"strings"

Expand Down Expand Up @@ -218,16 +219,16 @@ func (rm *resourceManager) updateConditions (
syncCondition = condition
}
}

if rm.terminalAWSError(err) || err == ackerr.SecretTypeNotSupported || err == ackerr.SecretNotFound {
var termError *ackerr.TerminalError
if rm.terminalAWSError(err) || err == ackerr.SecretTypeNotSupported || err == ackerr.SecretNotFound || errors.As(err, &termError) {
RedbackThomson marked this conversation as resolved.
Show resolved Hide resolved
if terminalCondition == nil {
terminalCondition = &ackv1alpha1.Condition{
Type: ackv1alpha1.ConditionTypeTerminal,
}
ko.Status.Conditions = append(ko.Status.Conditions, terminalCondition)
}
var errorMessage = ""
if err == ackerr.SecretTypeNotSupported || err == ackerr.SecretNotFound {
if err == ackerr.SecretTypeNotSupported || err == ackerr.SecretNotFound || errors.As(err, &termError) {
RedbackThomson marked this conversation as resolved.
Show resolved Hide resolved
errorMessage = err.Error()
} else {
awsErr, _ := ackerr.AWSError(err)
Expand Down