add real versions to controller main.go

[jaypipes]

I'd left a TODO in the main.go template for controllers to fill in their
GitVersion, GitCommit and BuildDate information properly. Just now
getting around to this...

Issue: aws-controllers-k8s/community#1171

Signed-off-by: Jay Pipes jaypipes@gmail.com

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

[vijtrip2]

/approve

@RedbackThomson feel free to merge if you have no concerns.

[RedbackThomson]

/approve

@RedbackThomson feel free to merge if you have no concerns.

I'd prefer not to have to modify every repositories Makefiles. I would rather we have them code generated tbh

[vijtrip2]

I'd prefer not to have to modify every repositories Makefiles. I would rather we have them code generated tbh

I think we won't need to. This PR will correctly use LDFlags from controller/pkg/version in main.go and the Dockerfile correctly sets those LDFLAGS when controller binary is built.

The LDFlags in controller Makefile are not used anywhere because binary is built in DockerFile which does not use Makefile.

[RedbackThomson]

Oh woah I did not notice that! That's confusing, but yay. I'm happy, then!
/lgtm

[ack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypipes, RedbackThomson, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RedbackThomson,jaypipes,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment