Additional nil checks during reference resolution #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycahta
approved these changes
Apr 21, 2022
| // useful to avoid nil pointer panics when accessing the referenced value. | ||
| // | ||
| // This function only outputs the logical condition and not the "if" block | ||
| // so that the output can be reused in many templates, where |
jaypipes
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
There is a problem with the assumption in the code that all components of the field path point to scalar Go types (or structs). However, this problem is present in the existing code and this PR doesn't need to be held up for it.
@vijtrip2 we can chat about a more robust solution that can handle map and slice field types.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brycahta, jaypipes, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
ReferencesConfig.Pathduring reference resolutionmain.go.tplBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.