Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crossplane's provider-aws has moved to the crossplane-contrib org #338

Merged
merged 1 commit into from
May 27, 2022

Conversation

negz
Copy link
Contributor

@negz negz commented May 27, 2022

Description of changes: This updates the templates accordingly.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from a-hilaly and jaypipes May 27, 2022 00:38
@ack-bot
Copy link
Collaborator

ack-bot commented May 27, 2022

Hi @negz. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-bot ack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 27, 2022
This updates the templates accordingly.

Signed-off-by: Nic Cope <nicc@rk0n.org>
@negz
Copy link
Contributor Author

negz commented May 27, 2022

CC @muvaf @haarchri

negz added a commit to negz/provider-aws that referenced this pull request May 27, 2022
negz added a commit to negz/provider-aws that referenced this pull request May 27, 2022
I'm guessing this is due to the ACK bump for aws-controllers-k8s/code-generator#338

Signed-off-by: Nic Cope <nicc@rk0n.org>
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jaypipes
Copy link
Collaborator

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented May 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypipes, negz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 6acf40f into aws-controllers-k8s:main May 27, 2022
@negz
Copy link
Contributor Author

negz commented May 27, 2022

Thanks @jaypipes!

@negz negz deleted the contrib branch May 27, 2022 03:46
negz added a commit to negz/provider-aws that referenced this pull request May 27, 2022
This generates controllers that import types from the crossplane-contrib
org per aws-controllers-k8s/code-generator#338

Signed-off-by: Nic Cope <nicc@rk0n.org>
emelieakerstrom-sb1 pushed a commit to sparebank1utvikling/provider-aws that referenced this pull request Sep 28, 2022
This generates controllers that import types from the crossplane-contrib
org per aws-controllers-k8s/code-generator#338

Signed-off-by: Nic Cope <nicc@rk0n.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants