Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm install check #359

Merged
merged 3 commits into from
Aug 20, 2022
Merged

Helm install check #359

merged 3 commits into from
Aug 20, 2022

Conversation

kskzk
Copy link
Contributor

@kskzk kskzk commented Aug 19, 2022

Issue #, if available: aws-controllers-k8s/community#1436

Description of changes:

  • Add helm version check function
  • Add helm installation helper script
  • Modify k8s_controller_gen_version_equals function and its comment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from brycahta and jaypipes August 19, 2022 03:01
@ack-bot ack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 19, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Aug 19, 2022

Hi @kskzk. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

a-hilaly
a-hilaly approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍
Thank you @kskzk !

@a-hilaly
Copy link
Member

/ok-to-test
/lgtm

@ack-bot ack-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2022
@a-hilaly
Copy link
Member

/retest

a-hilaly
a-hilaly reviewed Aug 19, 2022
View reviewed changes
scripts/lib/common.sh Outdated
@@ -1,6 +1,7 @@
#!/usr/bin/env bash

CONTROLLER_TOOLS_VERSION="v0.7.0"
HELM_VERSION="v3.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop the version to 3.7 ? i guess 3.9 is not required.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe we need to update our prow jobs to use 3.9 helm binaries..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm is installed here https://github.com/aws-controllers-k8s/test-infra/blob/da4dad6c57818a0d4f87f8e2ac9e608612bfaff8/prow/jobs/images/Dockerfile.auto-generate-controllers and few other dockerfiles in the same directory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!
Which do you think is better? Do we drop the minimum required version to 3.7 for now? If so, I will modify the pull request.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking that maybe we should start by dropping the version to 3.7 and dealing with the upgrade in a different PR

@ack-bot ack-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2022
@a-hilaly
Copy link
Member

Neat! Thank you @kskzk!
/approve
/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Aug 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, kskzk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit cdb0d99 into aws-controllers-k8s:main Aug 20, 2022
@kskzk kskzk deleted the helm-install-check branch August 20, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@brycahta brycahta Awaiting requested review from brycahta

@jaypipes jaypipes Awaiting requested review from jaypipes

Assignees

@a-hilaly a-hilaly

Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kskzk @ack-bot @a-hilaly