Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update aws-sdk-go dependency to v1.44.93 #362

Merged
merged 1 commit into from
Sep 12, 2022
Merged

update aws-sdk-go dependency to v1.44.93 #362

merged 1 commit into from
Sep 12, 2022

Conversation

brycahta
Copy link
Contributor

@brycahta brycahta commented Sep 8, 2022

Issue #, if available: N/A

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brycahta
Copy link
Contributor Author

brycahta commented Sep 8, 2022

All tests are passing, but the job fails with the same error for all controllers:

Error: INSTALLATION FAILED: YAML parse error on $CONTROLLER-chart/templates/cluster-role-controller.yaml: error converting YAML to JSON: yaml: line 8: did not find expected key

@brycahta
Copy link
Contributor Author

brycahta commented Sep 8, 2022

Not seeing these tests pass in the last couple code-generator PRs. @RedbackThomson @a-hilaly are these tests failing a known issue?

@a-hilaly
Copy link
Member

a-hilaly commented Sep 8, 2022

Hey @brycahta , no this is the first time i see a similar issue. Will investigate this.

@a-hilaly
Copy link
Member

a-hilaly commented Sep 8, 2022

/hold

@ack-bot ack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2022
@a-hilaly
Copy link
Member

/test dynamodb-controller-test

@a-hilaly
Copy link
Member

/unhold
/lgtm

@ack-bot ack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2022
@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, brycahta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 58c5ad9 into aws-controllers-k8s:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants