Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPAM and TPM to initialisms #365

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Add IPAM and TPM to initialisms #365

merged 1 commit into from
Sep 14, 2022

Conversation

brycahta
Copy link
Contributor

Issue #, if available: N/A

Description of changes: adds IPAM (IP Address Management) and TPM (Trusted Platform Module) to initialisms

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot
Copy link
Collaborator

ack-bot commented Sep 14, 2022

@brycahta: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
s3-controller-test 21c6d42 link /test s3-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@brycahta
Copy link
Contributor Author

@a-hilaly is s3-controller-test failure still expected? I know we discussed a couple days ago for this PR: #364 For reference:

Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muy bueno.

@ack-bot
Copy link
Collaborator

ack-bot commented Sep 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brycahta, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaypipes
Copy link
Collaborator

s3-controller test failure unrelated to this particular PR... merging as-is.

@jaypipes jaypipes merged commit 1da44f4 into aws-controllers-k8s:main Sep 14, 2022
@brycahta brycahta deleted the moar-names branch September 14, 2022 15:04
@a-hilaly
Copy link
Member

@a-hilaly is s3-controller-test failure still expected? I know we discussed a couple days ago for this PR: #364 For reference:

Yes i'm aware of these errors, i need to update s3 package in a seperate PR.

@a-hilaly
Copy link
Member

nit: @brycahta We should also port these changes to github.com/aws-controllers-k8s/pkg. I can take care of this task once we starting importing this package from github.com/aws-controllers-k8s/pkg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants