Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LNI to initialisms #368

Merged
merged 1 commit into from
Sep 26, 2022
Merged

add LNI to initialisms #368

merged 1 commit into from
Sep 26, 2022

Conversation

brycahta
Copy link
Contributor

Issue #, if available: N/A

Description of changes: adds LNI to initialisms with test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot
Copy link
Collaborator

ack-bot commented Sep 23, 2022

@brycahta: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
s3-controller-test 564db83 link /test s3-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, brycahta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 5ee0ac0 into aws-controllers-k8s:main Sep 26, 2022
Vandita2020 pushed a commit to Vandita2020/ack-code-generator that referenced this pull request Oct 24, 2022
Issue #, if available: N/A

Description of changes: adds LNI to initialisms with test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants