Add Helm support for the --deletion-policy CLI arg
#388
Conversation
|
/hold |
ack-bot
added
the
do-not-merge/hold
| @@ -203,6 +203,10 @@ | |||
| "pattern": "(^$|^.*=.*$)" | |||
| } | |||
| }, | |||
| "deletionPolicy": { | |||
| "type": "string", | |||
| "enum": ["delete", "retain"] | |||
There was a problem hiding this comment.
Since this enum is already enforced by the runtime here, what do you think about just making this a free-form string so that there is one fewer place where an enum needs to be updated if the values ever change?
There was a problem hiding this comment.
I want this here because I'd like the client-side Helm validation to fail if they try to add anything other than those values. Otherwise they would have to check the controller pod logs to understand what went wrong
|
/lgtm |
|
/unhold |
ack-bot
removed
the
do-not-merge/hold
RedbackThomson
changed the title
--deletion-policy CLI arg
|
/lgtm |
|
@jaypipes: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, jljaco, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Description of changes:
Adds a new value in
values.yamlnameddeletionPolicyto support the controller CLI argument--deletion-policy. Supports values ofdeleteandretainBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.