Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update common runtime to v0.23.0 #396

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Update common runtime to v0.23.0 #396

merged 3 commits into from
Jan 31, 2023

Conversation

RedbackThomson
Copy link
Contributor

Description of changes:
Updates the common runtime to v0.23.0

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from a-hilaly and vijtrip2 January 30, 2023 22:38
@RedbackThomson RedbackThomson changed the title Update common runtime to v0.23.0 Update common runtime to v0.23.0 Jan 30, 2023
a-hilaly
a-hilaly approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ack-bot
Copy link
Collaborator

ack-bot commented Jan 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [A-Hilaly,RedbackThomson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly
Copy link
Member

/cc @jljaco

@ack-bot ack-bot requested a review from jljaco January 31, 2023 00:32
@jljaco
Copy link
Contributor

jljaco commented Jan 31, 2023

/hold

I'd like to wait until our Prow upgrade is complete (or at least attempted and rolled back if necessary) before proceeding with this one.

@ack-bot ack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2023
@a-hilaly
Copy link
Member

/test all

1 similar comment
@a-hilaly
Copy link
Member

/test all

@jljaco
Copy link
Contributor

jljaco commented Jan 31, 2023

/unhold

@ack-prow ack-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2023
@a-hilaly
Copy link
Member

dabo-dancing
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2023
@ack-prow
Copy link

ack-prow bot commented Jan 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [A-Hilaly,RedbackThomson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit c3fefc1 into aws-controllers-k8s:main Jan 31, 2023
@RedbackThomson RedbackThomson deleted the runtime-0.23.0 branch January 31, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@vijtrip2 vijtrip2 Awaiting requested review from vijtrip2

@jljaco jljaco Awaiting requested review from jljaco

Assignees

@a-hilaly a-hilaly

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RedbackThomson @ack-bot @a-hilaly @jljaco