use Operation.ExportedName not Operation.Name
#424
Conversation
ack-prow
bot
added
the
needs-ok-to-test
|
Hi @jaypipes. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
ack-prow
bot
added
ok-to-test
a-hilaly
changed the title
Operation.ExportedName not Operation.Name
|
/test dynamodb-controller-test |
ack-prow
bot
added
the
do-not-merge/work-in-progress
This was a nasty issue to troubleshoot. :( Turns out that for REST+XML-based APIs (such as CloudFront), the aws-sdk-go `private/model/api.Operation` objects have a `Name` field that contains crap like this: "CreateCachePolicy2020_05_31". What this means is that when looking up things like output wrapper field paths by the `Operation.Name` of "CreateCachePolicy" (from the `generator.yaml` file's `operations` map), things were failing because the `private/model/api.API:Operations` map is actually keyed by `Operation.ExportedName`, not `Operation.Name`. `Operation.ExportedName` for REST+XML APIs like CloudFront contain the proper string "CreateCachePolicy" without the date suffix. Signed-off-by: Jay Pipes <jaypipes@gmail.com>
jaypipes
force-pushed
the
op-exported-name
branch
from
0fd367c to
abd79c3
Compare
ack-prow
bot
removed
the
do-not-merge/work-in-progress
|
@a-hilaly @RedbackThomson found a few more uses of |
|
@jaypipes: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was a nasty issue to troubleshoot. :( Turns out that for REST+XML-based APIs (such as CloudFront), the aws-sdk-go
private/model/api.Operationobjects have aNamefield that contains crap like this: "CreateCachePolicy2020_05_31". What this means is that when looking up things like output wrapper field paths by theOperation.Nameof "CreateCachePolicy" (from thegenerator.yamlfile'soperationsmap), things were failing because theprivate/model/api.API:Operationsmap is actually keyed byOperation.ExportedName, notOperation.Name.Operation.ExportedNamefor REST+XML APIs like CloudFront contain the proper string "CreateCachePolicy" without the date suffix.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.