Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin k8s.io/apimachinery to v0.26.1 andsigs.k8s.io/controller-runtime to v0.14.5 #425

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Pin k8s.io/apimachinery to v0.26.1 andsigs.k8s.io/controller-runtime to v0.14.5 #425

merged 1 commit into from
Mar 7, 2023

Conversation

a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented Mar 7, 2023

Similarily to aws-controllers-k8s/runtime#119..
upgrading the k8s libraries versions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@a-hilaly
Pin k8s.io/apimachinery to v0.26.1 and`sigs.k8s.io/controller-run…
0e36a0a 
…time to `v0.14.5`

Similarily to aws-controllers-k8s/runtime#119..
upgrading the k8s libraries versions.
@ack-prow ack-prow bot requested review from jljaco and vijtrip2 March 7, 2023 13:06
@ack-prow ack-prow bot added the approved label Mar 7, 2023
This was referenced Mar 7, 2023
Closed
Closed
@ack-prow
Copy link

ack-prow bot commented Mar 7, 2023

@a-hilaly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-controller-test 0e36a0a link true /test ec2-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jaypipes
jaypipes approved these changes Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RedbackThomson RedbackThomson changed the title Pin k8s.io/apimachinery to v0.26.1 andsigs.k8s.io/controller-runtime to v0.14.5` Pin k8s.io/apimachinery to v0.26.1 andsigs.k8s.io/controller-runtime to v0.14.5 Mar 7, 2023
@jljaco
Copy link
Contributor

jljaco commented Mar 7, 2023

This should be merged after aws-controllers-k8s/runtime#119

@a-hilaly
Copy link
Member Author

a-hilaly commented Mar 7, 2023

Waiting for aws-controllers-k8s/runtime#119 and a runtime release.
/hold

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2023
@ack-prow
Copy link

ack-prow bot commented Mar 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jaypipes, jljaco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly
Copy link
Member Author

a-hilaly commented Mar 7, 2023

/unhold

@ack-prow ack-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2023
@a-hilaly a-hilaly merged commit f8c4221 into aws-controllers-k8s:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jljaco jljaco jljaco approved these changes

@jaypipes jaypipes jaypipes approved these changes

@vijtrip2 vijtrip2 Awaiting requested review from vijtrip2

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-hilaly @jljaco @jaypipes