Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Go deps #427

Merged
merged 1 commit into from
Mar 10, 2023
Merged

chore: Update Go deps #427

merged 1 commit into from
Mar 10, 2023

Conversation

embano1
Copy link
Member

@embano1 embano1 commented Mar 10, 2023

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jljaco March 10, 2023 14:13
@embano1
chore: Update Go deps
11501ae 
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
@ack-prow
Copy link

ack-prow bot commented Mar 10, 2023 •
edited
Loading

@embano1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-controller-test 11501ae link true /test ec2-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jaypipes
jaypipes approved these changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failures are unrelated....

@ack-prow ack-prow bot added the approved label Mar 10, 2023
@jaypipes
Copy link
Collaborator

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2023
@ack-prow
Copy link

ack-prow bot commented Mar 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embano1, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly a-hilaly merged commit 14dcc10 into aws-controllers-k8s:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypipes jaypipes jaypipes approved these changes

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

@jljaco jljaco Awaiting requested review from jljaco

Assignees

@jaypipes jaypipes

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@embano1 @jaypipes @a-hilaly