Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GroupKind with GroupVersionKind in ResourceDescriptor #431

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

RedbackThomson
Copy link
Contributor

@RedbackThomson RedbackThomson commented Mar 21, 2023

Description of changes:
Replace GroupKind with GroupVersionKind, in ResourceDescriptor, which returns a static GVK using already-defined fields.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jljaco March 21, 2023 23:06
@ack-prow ack-prow bot added the approved label Mar 21, 2023
@RedbackThomson RedbackThomson changed the title Add GroupVersionKind to ResourceDescriptor Replace GroupKind with GroupVersionKind in ResourceDescriptor Mar 21, 2023
@ack-prow
Copy link

ack-prow bot commented Mar 21, 2023

@RedbackThomson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-controller-test eb94afe link true /test ec2-controller-test
apigatewayv2-controller-test eb94afe link true /test apigatewayv2-controller-test
s3-controller-test eb94afe link true /test s3-controller-test
dynamodb-controller-test eb94afe link true /test dynamodb-controller-test
iam-controller-test eb94afe link true /test iam-controller-test
ecr-controller-test eb94afe link true /test ecr-controller-test
lambda-controller-test eb94afe link true /test lambda-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-prow
Copy link

ack-prow bot commented Mar 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [A-Hilaly,RedbackThomson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly a-hilaly merged commit f60788f into aws-controllers-k8s:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants