Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template to support watch namespace #440

Merged
merged 2 commits into from
May 3, 2023
Merged

Update template to support watch namespace #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d27aa52
Update template to support watch namespace
rahtr May 1, 2023
c7da65b
Update templates/helm/values.yaml.tpl
rahtr May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/helm/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ If release name contains chart name it will be used as a full name.

{{- define "watch-namespace" -}}
{{- if eq .Values.installScope "namespace" -}}
{{- .Release.Namespace -}}
{{ .Values.watchNamespace | default .Release.Namespace }}
{{- end -}}
{{- end -}}

Expand Down
3 changes: 3 additions & 0 deletions templates/helm/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,9 @@
"type": "string",
"enum": ["cluster", "namespace"]
},
"watchNamespace": {
"type": "string"
},
"resourceTags": {
"type": "array",
"items": {
Expand Down
4 changes: 4 additions & 0 deletions templates/helm/values.yaml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ log:
# cluster wide.
installScope: cluster

# Set the value of the "namespace" to be watched by the controller
# This value is only used when the `installScope` is set to "namespace". If left empty, the default value is the release namespace for the chart.
watchNamespace: ""

resourceTags:
# Configures the ACK service controller to always set key/value pairs tags on
# resources that it manages.
Expand Down