Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hook for post_set_output #45

Merged
merged 1 commit into from
Apr 19, 2021
Merged

hook for post_set_output #45

merged 1 commit into from
Apr 19, 2021

Conversation

surajkota
Copy link
Member

Description of changes:

Adds a hook for post_set_output

Testing

Locally using sagemaker controller

TrainingJob:
    ...
    hooks:
      sdk_delete_pre_build_request:
        template_path: training_job/sdk_delete_pre_build_request.go.tpl
      sdk_create_post_set_output:
        template_path: training_job/sdk_create_post_set_output.go.tpl

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@surajkota surajkota requested a review from jaypipes April 19, 2021 22:44
@surajkota surajkota self-assigned this Apr 19, 2021
jaypipes
jaypipes approved these changes Apr 19, 2021
View reviewed changes
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock on :)

pkg/generate/ack/hook.go
The "post_set_output" hooks are called AFTER the the information from the API call
is merged with the copy of the original Kubernetes object. These hooks will
have access to the updated Kubernetes object `ko`, the response of the API call
(and the original Kubernetes CR object if its sdkUpdate)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome. :) thank you!

@jaypipes jaypipes merged commit b6d98fa into aws-controllers-k8s:main Apr 19, 2021
@surajkota surajkota mentioned this pull request Apr 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypipes jaypipes jaypipes approved these changes

Assignees

@surajkota surajkota

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surajkota @jaypipes