Replace hardcoded APIVersion with contextual APIVersion #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose R. Gonzalez <josegonzalez89@gmail.com>
RedbackThomson
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jose R. Gonzalez josegonzalez89@gmail.com
Hi folks!
Description of changes:
I inadvertently left in a hard-coded reference to the S3 APIVersion for the samples that are auto-generated from olmconfig. The result is that I was ending up with samples for kinds that weren't organized under the correct contextual APIVersion (in my case, I've been testing OLM generation against SageMaker as it has a wide variety of CRDs).
Discovered this bug in relation to the work being done here: aws-controllers-k8s/community#744 though it's not directly related to the goal of that issue (i.e. that bug should not be closed in relation to this PR).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
👍