Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct helm resource MCR flags #519

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented Mar 6, 2024

:hidding:, it looks like, i fat fingered before commit and the
e2e tests didn't catch this typo...

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

:hidding:, it looks like, i fat fingered before commit and the
 e2e tests didn't catch this typo...

Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
Copy link

ack-prow bot commented Mar 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2024
@ack-prow ack-prow bot requested review from jlbutler and jljaco March 6, 2024 20:34
@ack-prow ack-prow bot added the approved label Mar 6, 2024
@a-hilaly a-hilaly marked this pull request as ready for review March 6, 2024 20:34
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2024
@ack-bot
Copy link
Collaborator

ack-bot commented Mar 6, 2024

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
Copy link

ack-prow bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit a5ba3c8 into aws-controllers-k8s:main Mar 6, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants