Add support for empty shapes, used as booleans in SDK #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiberiuGC
force-pushed
the
feature/marker-shapes
branch
from
a9705b8 to
34e3d4b
Compare
|
@TiberiuGC this is great, i love it! Can you please provide an example generator.yaml in the PR description? |
TiberiuGC
force-pushed
the
feature/marker-shapes
branch
from
34e3d4b to
ec4cbc2
Compare
|
/retest |
TiberiuGC
force-pushed
the
feature/marker-shapes
branch
from
c00c657 to
c3a897b
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
TiberiuGC
force-pushed
the
feature/marker-shapes
branch
from
c3a897b to
3050ec1
Compare
TiberiuGC
changed the title
a-hilaly
approved these changes
Aug 14, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, TiberiuGC The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
ack-prow
bot
merged commit bdf3f26
into
aws-controllers-k8s:main
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: prerequisite for WAFv2 RuleGroup and WebACL CRDs
Description of changes:
Some WAFv2 API fields have empty json specs
{}, e.g. https://docs.aws.amazon.com/waf/latest/APIReference/API_AllQueryArguments.htmlFor these type of fields, codegen currently errors out because it infers their gotypes as e.g.
AllQueryArguments *AllQueryArgumentsbut does not generate a
type AllQueryArguments structsince the struct itself is empty, and not picked up bynewFieldRecursefunction.The solution proposed in this PR is to allow users to define
marker-shapes, which instruct codegen to overwrite the type of these empty structs as[]byte, both when generating the APIs and when setting up the SDK.e.g. generator.yaml for WAFv2, and inline:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.