Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Generate Code for resource adoption by annotation #558

Merged

Conversation

michaelhtm
Copy link
Member

Issue #, if available:

Description of changes:
These changes introduce a new generated function in all controllers
that attempts to populate the resource spec/status with fields defined
by the user.

This change will require for developers to add hooks for this function to
all controllers that already have a SetResourceIdentifiers hook.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler November 13, 2024 23:58
@michaelhtm michaelhtm force-pushed the feature/force-adoption branch from 00e6463 to 36e7af7 Compare November 19, 2024 18:28
@michaelhtm
Copy link
Member Author

/retest

@michaelhtm
Copy link
Member Author

/retest

2 similar comments
@michaelhtm
Copy link
Member Author

/retest

@michaelhtm
Copy link
Member Author

/retest

These changes introduce a new generated function in all controllers
that attempts to populate the resource spec/status with fields
defined by the user. This change will require for developers to
add hooks for this function to all controllers that already have a
`SetResourceIdentifiers` hook.
`post_set_resource_identifiers` to
@michaelhtm michaelhtm force-pushed the feature/force-adoption branch from 70e4d92 to 1c73e3b Compare December 2, 2024 12:46
@michaelhtm
Copy link
Member Author

/retest

Copy link

ack-prow bot commented Dec 2, 2024

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 1c73e3b link false /test verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
Copy link

ack-prow bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Dec 2, 2024
@ack-prow ack-prow bot merged commit 8f0f520 into aws-controllers-k8s:main Dec 2, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants