-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Generate Code for resource adoption by annotation #558
feature: Generate Code for resource adoption by annotation #558
Conversation
00e6463
to
36e7af7
Compare
/retest |
36e7af7
to
70e4d92
Compare
/retest |
2 similar comments
/retest |
/retest |
These changes introduce a new generated function in all controllers that attempts to populate the resource spec/status with fields defined by the user. This change will require for developers to add hooks for this function to all controllers that already have a `SetResourceIdentifiers` hook. `post_set_resource_identifiers` to
70e4d92
to
1c73e3b
Compare
/retest |
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
Description of changes:
These changes introduce a new generated function in all controllers
that attempts to populate the resource spec/status with fields defined
by the user.
This change will require for developers to add hooks for this function to
all controllers that already have a
SetResourceIdentifiers
hook.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.