Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hooks after input request creation, but before request is submitted. #56

Merged
merged 1 commit into from
May 7, 2021

Conversation

mbaijal
Copy link
Contributor

@mbaijal mbaijal commented May 7, 2021

Description of changes

Adds the post_build_request hooks which are called AFTER the call to construct the Input shape but BEFORE the API operation.

Sample Use:

resources:
  ScalableTarget:
    hooks:
        sdk_read_many_post_build_request:
          code: rm.customDescribeScalableTarget(ctx, r, input)

Testing

Fixed the bug in applicationAutoscaling where one could not create a ScalableTarget resource which would throw the following error -

Reconciler error	{"controller": "scalabletarget", "request": "default/dynamodb-scalable-target-2ir12cp", "error": "ValidationException: Scalable dimension cannot be provided without resource IDs."}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, nice addition, thank you @mbaijal!

@ack-bot
Copy link
Collaborator

ack-bot commented May 7, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaypipes, mbaijal, surajkota

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaypipes jaypipes merged commit 71f5331 into aws-controllers-k8s:main May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants