Add hook code to PopulareResourceFromAnnotation
#560
Conversation
Hooks: * `pre_populate_resource_from_annotation` * `post_populate_resource_from_annotation` This function is similar to the `SetIdentifiers` function. If any controller has a hook for `SetIdentifiers`, we need a similar one for `PopulateResourceFromAnnotation`
michaelhtm
force-pushed
the
addoption/hook
branch
from
06b4c97 to
605262a
Compare
|
/retest |
1 similar comment
|
/retest |
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes:
This function is similar to the
SetIdentifiersfunction.If any controller has a hook for
SetIdentifiers, we needa similar one for
PopulateResourceFromAnnotationHooks:
pre_populate_resource_from_annotationpost_populate_resource_from_annotationBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.