Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace scope service controllers #60

Merged
merged 3 commits into from
May 14, 2021
Merged

Namespace scope service controllers #60

merged 3 commits into from
May 14, 2021

Conversation

akartsky
Copy link
Member

@akartsky akartsky commented May 11, 2021 •
edited
Loading

Add ability to listen to specific namespace for service controllers
Tested locally for both positive and negative case

aws-controllers-k8s/community#686

Related PR:
aws-controllers-k8s/runtime#12

@akartsky akartsky mentioned this pull request May 11, 2021
Merged
@surajkota
Copy link
Member

add testing information

@RedbackThomson
Copy link
Contributor

Regarding our discussion for ClusterRole and scope issues: aws-controllers-k8s/community#770

@a-hilaly
Copy link
Member

a-hilaly commented May 12, 2021 •
edited
Loading

Can we support watching multiple namespaces at once instead of only one?

@akartsky
Copy link
Member Author

Can we support watching multiple namespaces at once instead of only one?

Yes i need to spend more time on this

This is just a quick PR to have the feature out

jaypipes
jaypipes approved these changes May 14, 2021
View reviewed changes
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

good to merge after the associated runtime PR merges.

jaypipes
jaypipes requested changes May 14, 2021
View reviewed changes
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akartsky please update the go.mod to point to the just-curt v0.2.0 release of runtime:

https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.2.0

jaypipes
jaypipes approved these changes May 14, 2021
View reviewed changes
go.mod
@@ -3,7 +3,7 @@ module github.com/aws-controllers-k8s/code-generator
go 1.14

require (
github.com/aws-controllers-k8s/runtime v0.1.0
github.com/aws-controllers-k8s/runtime v0.2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ack-bot
Copy link
Collaborator

ack-bot commented May 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, akartsky, jaypipes, surajkota

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaypipes jaypipes merged commit cba1bea into aws-controllers-k8s:main May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surajkota surajkota surajkota approved these changes

@a-hilaly a-hilaly a-hilaly approved these changes

@jaypipes jaypipes jaypipes approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akartsky @surajkota @RedbackThomson @a-hilaly @ack-bot @jaypipes