helm chart: add log and accountid

[surajkota]

Issue #, if available: aws-controllers-k8s/community#787

Tested using sagemaker-controller

k get pods -n ack-system -ojson

"spec": {
                "containers": [
                    {
                        "args": [
                            "--aws-account-id",
                            "$(AWS_ACCOUNT_ID)",
                            "--aws-region",
                            "$(AWS_REGION)",
                            "--enable-development-logging",
                            "$(ACK_ENABLE_DEVELOPMENT_LOGGING)",
                            "--log-level",
                            "$(ACK_LOG_LEVEL)",
                            "--resource-tags",
                            "$(ACK_RESOURCE_TAGS)",
                            "--watch-namespace",
                            "$(ACK_WATCH_NAMESPACE)"
                        ],
                        "command": [
                            "./bin/controller"
                        ],
                        "env": [
                            {
                                "name": "K8S_NAMESPACE",
                                "valueFrom": {
                                    "fieldRef": {
                                        "apiVersion": "v1",
                                        "fieldPath": "metadata.namespace"
                                    }
                                }
                            },
                            {
                                "name": "AWS_ACCOUNT_ID",
                                "value": "xxx"
                            },
                            {
                                "name": "AWS_REGION",
                                "value": "us-west-2"
                            },
                            {
                                "name": "ACK_WATCH_NAMESPACE"
                            },
                            {
                                "name": "ACK_ENABLE_DEVELOPMENT_LOGGING",
                                "value": "true"
                            },
                            {
                                "name": "ACK_LOG_LEVEL",
                                "value": "INFO"
                            },
                            {
                                "name": "ACK_RESOURCE_TAGS",
                                "value": "services.k8s.aws/managed=true,services.k8s.aws/created=%UTCNOW%,services.k8s.aws/namespace=%KUBERNETES_NAMESPACE%"
                            },
                            {
                                "name": "AWS_ROLE_ARN",
                                "value": "arn:aws:iam::xxx:role/ack-sage-role-ack-bug-bash-may18"
                            },
                            {
                                "name": "AWS_WEB_IDENTITY_TOKEN_FILE",
                                "value": "/var/run/secrets/eks.amazonaws.com/serviceaccount/token"
                            }
                        ],

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[surajkota]

DEBUG did not work, hence I kept it as info and not INFO

[RedbackThomson]

The ./kind-build-test.sh script has this set to debug, but I don't think that's appropriate for production use anyway. I think this is good.

[surajkota]

Actually, I am inclined to keep default as debug because info logs are very less and hard to relate with state of resource. I think even the delta is not printed in info. Let's see what others have to say.

[jaypipes]

Actually, I am inclined to keep default as debug because info logs are very less and hard to relate with state of resource. I think even the delta is not printed in info. Let's see what others have to say.

Delta is shown in Info, actually: https://github.com/aws-controllers-k8s/runtime/blob/main/pkg/runtime/reconciler.go#L251

I would prefer to use info level for default.

[jaypipes]

@surajkota is correct. We are logging the diff/delta using V(1) (debug) not info...

That said, I would prefer to merge this with info as the default log level and address specific log messages (and moving some to info vs debug, etc) in a separate PR.

[surajkota]

Makes sense, I can create a separate issue/pr for that

[ack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RedbackThomson, surajkota

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RedbackThomson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[a-hilaly]

@RedbackThomson PTAL at my comments on aws-controllers-k8s/test-infra#27

/hold

[a-hilaly]

/unhold

[RedbackThomson]

/lgtm