-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ElastiCache CodeGen test based on new SDK #75
Conversation
@nmvk no changes to the sdk.go generation? |
@nmvk what changes does this version bring exactly? This repository is using |
Update json files in test to use v1.38.52. Used ReplicationGroup for some old tests and updated generator.yaml to potentially match elasticache.
/test all |
@a-hilaly: No jobs can be run with
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test unit-test |
Thanks! Yes i agree that it is a bit confusing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, nmvk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ElastiCache would use new AWS SDK Go to include new features like LogDelivery which are currently not part of
elasticache-controller
. This PR updates the test data used in code generator for Elasticache tests.Additionally I have updated
generator.yaml
to be inline with one being used inelasticache-controller
. Updated unit tests which useCacheCluster
resource toReplicationGroup
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.